Skip to content

[testing] move pytest to be inside the function#4087

Merged
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/cli-pytest
Jun 27, 2023
Merged

[testing] move pytest to be inside the function#4087
FrankLeeeee merged 1 commit intohpcaitech:mainfrom
FrankLeeeee:hotfix/cli-pytest

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Fixed #3962

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR moved import pytest to the function body so that it will not affect users who use the CLI.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@github-actions
Copy link
Copy Markdown
Contributor

The code coverage for the changed files is 75%.

Click me to view the complete report
Name                                   Stmts   Miss  Cover
----------------------------------------------------------
colossalai/testing/pytest_wrapper.py      12      3    75%
----------------------------------------------------------
TOTAL                                     12      3    75%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: pytest and decorator required but missing in v0.3.0 requirements

2 participants