Skip to content

[hotfix] fix argument naming in docs and examples#4083

Merged
Fridge003 merged 1 commit intohpcaitech:mainfrom
Fridge003:hotfix/gemini_argument_renaming
Jun 26, 2023
Merged

[hotfix] fix argument naming in docs and examples#4083
Fridge003 merged 1 commit intohpcaitech:mainfrom
Fridge003:hotfix/gemini_argument_renaming

Conversation

@Fridge003
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

The argument renaming in #4056 is not comprehensive. Some examples & docs need to use the renamed arguments, but they are out of the scope of unit tests, so I'm making this complement PR.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@Fridge003 Fridge003 requested review from cwher and ver217 June 26, 2023 05:01
@Fridge003 Fridge003 force-pushed the hotfix/gemini_argument_renaming branch from 837b367 to ca8d01f Compare June 26, 2023 06:08
@cwher cwher removed their request for review June 26, 2023 06:09
@Fridge003 Fridge003 force-pushed the hotfix/gemini_argument_renaming branch 2 times, most recently from 9f263a6 to 59ee014 Compare June 26, 2023 08:20
@Fridge003 Fridge003 force-pushed the hotfix/gemini_argument_renaming branch from 59ee014 to 95295bd Compare June 26, 2023 08:35
@Fridge003 Fridge003 changed the title [hotfix]fix argument naming in docs and examples [hotfix] fix argument naming in docs and examples Jun 26, 2023
@Fridge003 Fridge003 merged commit 4da324c into hpcaitech:main Jun 26, 2023
@Fridge003 Fridge003 deleted the hotfix/gemini_argument_renaming branch June 27, 2023 03:50
FrankLeeeee pushed a commit to FrankLeeeee/ColossalAI that referenced this pull request Jul 4, 2023
ver217 pushed a commit to ver217/ColossalAI that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants