[gemini] Fix a bug in chunk configuration searching#4056
Merged
Fridge003 merged 1 commit intohpcaitech:mainfrom Jun 25, 2023
Merged
[gemini] Fix a bug in chunk configuration searching#4056Fridge003 merged 1 commit intohpcaitech:mainfrom
Fridge003 merged 1 commit intohpcaitech:mainfrom
Conversation
ver217
approved these changes
Jun 21, 2023
833a88d to
852f9ca
Compare
852f9ca to
0bb0b48
Compare
Contributor
|
The code coverage for the changed files is 89%. Click me to view the complete report |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Checklist before creating the PR
[doc/gemini/tensor/...]: A concise description🚨 Issue number
#4052
📝 What does this PR do?
Since the chunk_size attribute in Gemini should be used in number of elements, the modification proposed in #4052 can't be adopted.
Instead, to avoid confusion, arguments including
search_range_mb,min_chunk_size_mbandsearch_interval_bytesshould be renamed tosearch_range_m,min_chunk_size_mandsearch_interval. In this way, there should be no doubt that chunk_size takes number of elements as its unit rather than number of bytes.Also, some tests are modified due to this renaming of arguments.
💥 Checklist before requesting a review
⭐️ Do you enjoy contributing to Colossal-AI?
Tell us more if you don't enjoy contributing to Colossal-AI.