Skip to content

[docker] fixed ninja build command#4203

Merged
FrankLeeeee merged 2 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/docker-ninja-build
Jul 10, 2023
Merged

[docker] fixed ninja build command#4203
FrankLeeeee merged 2 commits intohpcaitech:mainfrom
FrankLeeeee:hotfix/docker-ninja-build

Conversation

@FrankLeeeee
Copy link
Copy Markdown
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

N/A, a continuation of #4192

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the docker build error due to ninja-build.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee merged commit c1cf752 into hpcaitech:main Jul 10, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/docker-ninja-build branch July 10, 2023 03:48
jamesthesnake added a commit to jamesthesnake/ColossalAI that referenced this pull request Jul 10, 2023
[docker] fixed ninja build command (hpcaitech#4203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants