Skip to content

[docker] fixed ninja build command (#4203)#89

Merged
jamesthesnake merged 1 commit intojamesthesnake:rafrom
hpcaitech:main
Jul 10, 2023
Merged

[docker] fixed ninja build command (#4203)#89
jamesthesnake merged 1 commit intojamesthesnake:rafrom
hpcaitech:main

Conversation

@jamesthesnake
Copy link
Copy Markdown
Owner

  • [docker] fixed ninja build command

  • polish code

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

* [docker] fixed ninja build command

* polish code
@jamesthesnake jamesthesnake merged commit 6067ad4 into jamesthesnake:ra Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants