Skip to content

[chat] fix compute_approx_kl#4338

Merged
ver217 merged 1 commit intohpcaitech:mainfrom
cwher:main
Aug 1, 2023
Merged

[chat] fix compute_approx_kl#4338
ver217 merged 1 commit intohpcaitech:mainfrom
cwher:main

Conversation

@cwher
Copy link
Copy Markdown
Contributor

@cwher cwher commented Jul 27, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

Close #3696.

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@cwher cwher requested a review from ver217 July 27, 2023 06:52
@ver217 ver217 merged commit 75c5389 into hpcaitech:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: wrong in KL_approx , the order of two distribution is handled incorrectly

2 participants