Xsnprintf to stringutils

[BenBE]

This is a follow-up patch after #155 as asked for by @fasterit …

I'd appreciate it if we could do this one after #155, #156 and #160.

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 2.596 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

[cgzones]

Personally I do not like the names String_asprintf, String snprintf and String_strdup, because it might not be obvious what the differences to the standard functions are.
The x prefix for allocation wrappers is somewhat common to signal a checked or garbage-collected allocation, so xasprintf might be easier translated into checked asprintf.

But if @fasterit or @natoscott is fine with the naming, I'll go along.

[fasterit]

Personally I do not like the names String_asprintf, String snprintf and String_strdup, because it might not be obvious what the differences to the standard functions are.
The x prefix for allocation wrappers is somewhat common to signal a checked or garbage-collected allocation, so xasprintf might be easier translated into checked asprintf.

But if @fasterit or @natoscott is fine with the naming, I'll go along.

How about renaming StringUtils.{h|c} to XUtils.{h|c} and joining the remainder of XAlloc.{h|c} into this (i.e. XAlloc.{h|c} files (not functions) cease to exist)?
This way we could easily stay with naming functions xSnprintf and alike. That means this PR has much less noise where the functions are used, just cleaned and more logical includes.

[BenBE]

I basically see 4 options to proceed here:

1. Keep xSnprintf, xAsprintf and xStrdup in XAlloc.[ch] (AS IS)
2. Move xSnprintf, xAsprintf and xStrdup to StringUtils.[ch], but keep current names (first patch only)
3. Move xSnprintf, xAsprintf and xStrdup to StringUtils.[ch], rename for consistency (both patches)
4. Join xSnprintf, xAsprintf, xStrdup and StringUtils.[ch] into new XUtils.[ch], but keep current names
5. Join xSnprintf, xAsprintf, xStrdup and StringUtils.[ch] into new XUtils.[ch], and adjust functions String_* names for consistency
6. Yet another option.

My personal favorite is variant 2.

FWIW: Currently #160 builds on this PR, but I can separate them quite easily if discussion here still needs more time and we want to unblock the include cleanup PR in the meantime. Rebasing the last two commits of #160 requires IWYU anyway, so makes no big difference which commit I rebase it onto.

[fasterit]

4. Join `xSnprintf`, `xAsprintf`, `xStrdup` and `StringUtils.[ch]` into new `XUtils.[ch]`, but keep current names

My favorite.
/DLange

[BenBE]

Could someone please check the deepcode issue? I don't understand what TF it want's to be done …

[cgzones]

LGTM

[fasterit]

Merged, thank you very much. Much appreciated cleanup work!