command screen: fill current line when scanning#185
Merged
cgzones merged 1 commit intohtop-dev:masterfrom Sep 29, 2020
ryenus:cmd-scr
Merged
command screen: fill current line when scanning#185cgzones merged 1 commit intohtop-dev:masterfrom ryenus:cmd-scr
cgzones merged 1 commit intohtop-dev:masterfrom
ryenus:cmd-scr
Conversation
Contributor
Author
|
@cgzones would you please take a look? Nevertheless the numbers are machine specific, YMMV. |
BenBE
approved these changes
Sep 28, 2020
Member
BenBE
left a comment
BenBE
left a comment
There was a problem hiding this comment.
LGTM.
Don't quite like the back-addressing in p - line_offset, but overall it's okay nonetheless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After pr #67 got merged, @BenBE proposed the option to fill the current line
while scanning the command, rather than using a separate
memcpyafterward.So I gave it a try and measured the difference.
For short commands there's not much difference, but when a command is relatively
long, e.g., the longest I could find, of a java process, is about 7k+
characters, per my test, in the best case, it's about 30 vs 28 (ms) on average
before and after, So the copy-on-scan approach won with a little margin.