Skip to content

use separate window/screen to show long commands in multiple lines#67

Merged
cgzones merged 1 commit intohtop-dev:masterfrom
ryenus:cmd-scr
Sep 24, 2020
Merged

use separate window/screen to show long commands in multiple lines#67
cgzones merged 1 commit intohtop-dev:masterfrom
ryenus:cmd-scr

Conversation

@ryenus
Copy link
Copy Markdown
Contributor

@ryenus ryenus commented Sep 2, 2020

With this change the command of the highlighted process can be shown in
a separate window, and wrapped into multiple lines.

Here's a screenshot showing a Chrome process with a long command:

image

@cgzones cgzones added needs-rebase Pull request needs to be rebased and conflicts to be resolved RFE labels Sep 12, 2020
@ryenus ryenus requested a review from cgzones September 14, 2020 01:44
@ryenus
Copy link
Copy Markdown
Contributor Author

ryenus commented Sep 14, 2020

I just realized that the tab char (\t) is displayed as a question mark (?), so we only wrap by space now:

image

@ryenus
Copy link
Copy Markdown
Contributor Author

ryenus commented Sep 14, 2020

@cgzones rebase done as well.

@cgzones cgzones removed the needs-rebase Pull request needs to be rebased and conflicts to be resolved label Sep 21, 2020
For a process with a very long command, especially with many long
command line arguments, inspecting the command and its arguments could
become inconvenient.

Meanwhile htop supports the concept of "screen", or window, which is
extended here to create a dedicated "CommandScreen", making it possible
to display the command of the selected process in a separate window
meanwhile being wrapped into multiple lines.

Another benefit of using a command screen is, the user can navigate
through the wrapped lines of the command and perform actions like
searching and filtering.
@cgzones cgzones merged commit f4bb502 into htop-dev:master Sep 24, 2020
@cgzones
Copy link
Copy Markdown
Member

cgzones commented Sep 24, 2020

Thanks, applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants