Skip to content

Improved command display#305

Merged
BenBE merged 12 commits intohtop-dev:masterfrom
BenBE:improved-command-display
Nov 24, 2020
Merged

Improved command display#305
BenBE merged 12 commits intohtop-dev:masterfrom
BenBE:improved-command-display

Conversation

@BenBE
Copy link
Copy Markdown
Member

@BenBE BenBE commented Nov 8, 2020

Replaces #42

State:

  • Rebased onto master
  • Adds command line space heuristic

Open issues:

  • Only show magenta for things that changed in merged view

Note for faccessat: This currently only implements the specific case required for this PR.
Assumptions are documented in the function implementation.
If someone feels there should be a full compat layer for this function I'd appreciate a small patch.

For other caveats see the original PR discussion.

@fasterit fasterit added the needs-rebase Pull request needs to be rebased and conflicts to be resolved label Nov 17, 2020
@BenBE BenBE force-pushed the improved-command-display branch from 3382ca7 to 6e2ee22 Compare November 20, 2020 00:01
@BenBE BenBE removed the needs-rebase Pull request needs to be rebased and conflicts to be resolved label Nov 20, 2020
@fasterit
Copy link
Copy Markdown
Member

Very nice work!

Can you please replace "?" with "no perm" as in the DISK I/O meters for visual consistency.
For that reason also use their color (PROCESS_SHADOW). There is no reason for a failed read to be an alerting red. This is expected when running htop as a user.

@BenBE BenBE force-pushed the improved-command-display branch from f52e810 to c1502c1 Compare November 21, 2020 15:00
@BenBE BenBE force-pushed the improved-command-display branch from d9c6044 to 5e4c0d4 Compare November 23, 2020 21:58
…ches basename from cmdline

Also highlights entries where exe was marked deleted
@marxin
Copy link
Copy Markdown

marxin commented Nov 25, 2020

Thank you guys, it's a nice improvement!
Kudos!

@BenBE BenBE mentioned this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants