Skip to content

Add support to change numeric options in settings screen#333

Merged
cgzones merged 1 commit intohtop-dev:masterfrom
cgzones:option
Nov 25, 2020
Merged

Add support to change numeric options in settings screen#333
cgzones merged 1 commit intohtop-dev:masterfrom
cgzones:option

Conversation

@cgzones
Copy link
Copy Markdown
Member

@cgzones cgzones commented Nov 22, 2020

Like delay or highlightDelaySecs

Copy link
Copy Markdown
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

@cgzones cgzones force-pushed the option branch 2 times, most recently from 7021f73 to aca376e Compare November 24, 2020 16:00
@cgzones
Copy link
Copy Markdown
Member Author

cgzones commented Nov 24, 2020

Note: when merging, check for new introduced configuration settings and remove redundant xstrdup calls in first arguments of CheckItem_newByRef/CheckItem_newByValue. (e.g. #305)

@BenBE BenBE added the needs-rebase Pull request needs to be rebased and conflicts to be resolved label Nov 24, 2020
@cgzones cgzones removed the needs-rebase Pull request needs to be rebased and conflicts to be resolved label Nov 24, 2020
Copy link
Copy Markdown
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space with -H10000 one too little, but still acceptable.

@cgzones cgzones merged commit 267014c into htop-dev:master Nov 25, 2020
@cgzones cgzones deleted the option branch November 25, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants