Skip to content

Linux: check processes for using deleted shared libraries#595

Merged
cgzones merged 1 commit intohtop-dev:masterfrom
cgzones:dynlib1
Jun 9, 2021
Merged

Linux: check processes for using deleted shared libraries#595
cgzones merged 1 commit intohtop-dev:masterfrom
cgzones:dynlib1

Conversation

@cgzones
Copy link
Copy Markdown
Member

@cgzones cgzones commented Apr 9, 2021

Shared libraries can be replaced by an upgrade, highlight processes
using deleted shared libraries.

Link with highlightDeletedExe setting, enabled by default.

Currently only checked on Linux.

@BenBE
Copy link
Copy Markdown
Member

BenBE commented Apr 9, 2021

What about combining this with #414?

Copy link
Copy Markdown
Member

@BenBE BenBE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch itself LGTM, but I still wonder if we really should split the two features, especially as #414 more or less implies this flag is also triggered.

@cgzones cgzones force-pushed the dynlib1 branch 2 times, most recently from 5cce10b to 3a09221 Compare April 26, 2021 16:16
@cgzones cgzones added this to the 3.0.6 milestone Apr 26, 2021
@cgzones
Copy link
Copy Markdown
Member Author

cgzones commented Apr 26, 2021

Postpone after #414 to merge enable-logic with deleted executables.

@cgzones cgzones marked this pull request as draft April 26, 2021 16:21
@alicektx
Copy link
Copy Markdown

alicektx commented May 6, 2021

...really really thank you for doing / implementing this ability into htop! had been using this so far to check such...

@BenBE
Copy link
Copy Markdown
Member

BenBE commented May 23, 2021

@cgzones Could you update this now that #414 is merged?
Please note the earlier review comment #595 (review).

@cgzones cgzones marked this pull request as ready for review May 23, 2021 13:27
Shared libraries can be replaced by an upgrade, highlight processes
using deleted shared libraries.

Link with highlightDeletedExe setting, enabled by default.

Currently only checked on Linux.
@cgzones cgzones merged commit 8154125 into htop-dev:master Jun 9, 2021
@cgzones cgzones deleted the dynlib1 branch June 9, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants