Skip to content

Make highlighting of deleted executables configurable#414

Merged
BenBE merged 3 commits intohtop-dev:masterfrom
BenBE:exe_del_option
May 23, 2021
Merged

Make highlighting of deleted executables configurable#414
BenBE merged 3 commits intohtop-dev:masterfrom
BenBE:exe_del_option

Conversation

@BenBE
Copy link
Copy Markdown
Member

@BenBE BenBE commented Dec 19, 2020

Addresses #383. Also updates documentation of the highlighting.

Should go in AFTER #388 due to code dependencies.

@fasterit fasterit added this to the 3.0.6 milestone Dec 24, 2020
@fasterit
Copy link
Copy Markdown
Member

fasterit commented Dec 24, 2020

Milestoned to 3.0.6 due to dependency on #388.
DLange still thinks this one need not be configurable. Users should know when executables have been deleted. Not wanting to know is ... a very odd us case for running a system monitoring application like htop.

@BenBE BenBE force-pushed the exe_del_option branch 2 times, most recently from 0968d46 to 064590f Compare December 25, 2020 12:25
@BenBE BenBE added the needs-discussion 🤔 Changes need to be discussed and require consent label Dec 25, 2020
@BenBE
Copy link
Copy Markdown
Member Author

BenBE commented Dec 25, 2020

See also the related discussion in #376 (comment) …

@milosivanovic
Copy link
Copy Markdown

milosivanovic commented Dec 25, 2020

See also the related discussion in #376 (comment) …

I wasn't sure if the discussion should be here or in #376. I responded to @fasterit's comment there.

@BenBE
Copy link
Copy Markdown
Member Author

BenBE commented Dec 26, 2020

See also the related discussion in #376 (comment) …

I wasn't sure if the discussion should be here or in #376. I responded to @fasterit's comment there.

Let's just keep the discussion central in #376. The "needs-discussion" label on this issue is mostly a team-internal marker for planning and coordinating things.

cgzones
cgzones reviewed Mar 17, 2021
View reviewed changes
@BenBE BenBE force-pushed the exe_del_option branch 3 times, most recently from 4b2831c to 17fd61c Compare March 20, 2021 13:49
@BenBE BenBE mentioned this pull request Apr 9, 2021
Merged
@BenBE BenBE force-pushed the exe_del_option branch 2 times, most recently from 25757e9 to e209770 Compare April 10, 2021 10:04
@BenBE BenBE force-pushed the exe_del_option branch 4 times, most recently from 3efc1e4 to a4655df Compare April 24, 2021 11:20
@BenBE BenBE force-pushed the exe_del_option branch from 10cd09e to 94cb080 Compare May 8, 2021 19:09
@BenBE BenBE force-pushed the exe_del_option branch 6 times, most recently from 54624b5 to 2d43fe9 Compare May 22, 2021 14:12
@BenBE BenBE force-pushed the exe_del_option branch 2 times, most recently from 170b8b6 to 78ba126 Compare May 23, 2021 00:59
@BenBE BenBE force-pushed the exe_del_option branch from 78ba126 to c4ba26b Compare May 23, 2021 07:25
@BenBE BenBE merged commit 771a1be into htop-dev:master May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgzones cgzones cgzones approved these changes

Assignees

No one assigned

Labels

needs-discussion 🤔 Changes need to be discussed and require consent

Projects

None yet

Milestone

3.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@BenBE @fasterit @milosivanovic @cgzones