Update the legacy inpainting SD pipeline, to allow calling it with only prompt_embeds (instead of always requiring a prompt) #2842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream
…is called only with prompt_embeds
cmdr2
added a commit
to easydiffusion/sdkit
that referenced
this pull request
Mar 27, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
cmdr2
changed the title
Contributor
|
Great, good job on correcting this! |
w4ffl35
pushed a commit
to w4ffl35/diffusers
that referenced
this pull request
Apr 14, 2023
…ly prompt_embeds (instead of always requiring a prompt) (huggingface#2842) Fix error 'required positional argument: prompt' when Legacy Inpaint is called only with prompt_embeds
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…ly prompt_embeds (instead of always requiring a prompt) (huggingface#2842) Fix error 'required positional argument: prompt' when Legacy Inpaint is called only with prompt_embeds
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…ly prompt_embeds (instead of always requiring a prompt) (huggingface#2842) Fix error 'required positional argument: prompt' when Legacy Inpaint is called only with prompt_embeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are already present in the
StableDiffusionPipelineand other classes. Borrowed these changes from: https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion.py#L517This PR fixes the
required positional argument: prompterror thrown byStableDiffusionInpaintPipelineLegacywhen called with onlyprompt_embeds. For e.g. if using thecompellibrary.It also corrects the
batch_sizeused whenprompt_embedsare passed to the function (borrowed this change too from the SD pipeline).Thanks!