Update the K-Diffusion SD pipeline, to allow calling it with only prompt_embeds (instead of always requiring a prompt) #2962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream
Upstream
…mpt_embeds (instead of always requiring a prompt)
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
Separate from this PR - Any objections to a The current state probably made sense (so far), to allow each pipeline to evolve independently and quickly. But maybe some functions are now stable and common-enough among the different SD pipelines? Thanks! |
Contributor
|
Works for me! @sayakpaul what do you think? |
patrickvonplaten
approved these changes
Apr 4, 2023
sayakpaul
approved these changes
Apr 5, 2023
Member
sayakpaul
left a comment
sayakpaul
left a comment
There was a problem hiding this comment.
Thanks a lot!
Completely optional -- would be cool to have a test for prompt_embeds.
w4ffl35
pushed a commit
to w4ffl35/diffusers
that referenced
this pull request
Apr 14, 2023
…mpt_embeds (instead of always requiring a prompt) (huggingface#2962)
dg845
pushed a commit
to dg845/diffusers
that referenced
this pull request
May 6, 2023
…mpt_embeds (instead of always requiring a prompt) (huggingface#2962)
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
…mpt_embeds (instead of always requiring a prompt) (huggingface#2962)
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
…mpt_embeds (instead of always requiring a prompt) (huggingface#2962)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #2842 (merged)
These changes are already present in the StableDiffusionPipeline and other classes. Borrowed these changes from: https://github.com/huggingface/diffusers/blob/main/src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion.py#L517
Thanks!