Conversation
Contributor
Author
|
CI was failing on an un-related test: It is due to this commit on I fixed the expected result in ec14a49. |
|
Thank you for fixing this! |
Contributor
|
not to forget this dev change: 8c6163b |
xenova
approved these changes
Sep 20, 2023
This reverts commit 8c6163b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes the CI for https://github.com/huggingface/course and in particular ./es/chapter5/5.mdx.
Related to this slack thread (internal) and this failing CI.
The failing doc had this form:
in which the
_re_lt_htmlregex detected<n<100K \n<Tip>as a single HTML tag. The_re_lt_htmlis meant to detect the<characters that are not part of a HTML tag.I fixed the regex for this use case + added a regression test for it. All previous unit tests are still passing so hopefully it doesn't break something in the wild. I also took the liberty to add verbose mode to explain a bit more what the regex is doing (too me a bit of time to remember 🙄).
cc @mishig25 @MKhalusova @xenova
(also related to #373 and #394 which introduced and modified this regex)