Add doc_builder_revision as workflow input to ease debugging#399
Merged
Add doc_builder_revision as workflow input to ease debugging#399
doc_builder_revision as workflow input to ease debugging#399Conversation
Contributor
Author
|
CI will fail because of #398 (comment) but not related to this PR. |
mishig25
approved these changes
Sep 21, 2023
Contributor
mishig25
left a comment
mishig25
left a comment
There was a problem hiding this comment.
lgtm! Amazing
Could you add a small section on readme telling that: when you are testing a new doc build, you need to do
- Set the
uses: huggingface/doc-builder/.github/workflows/build_pr_documentation.yml@{YOUR BRANCH} - And provide this argument
doc_builder_revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't change much for existing repo (will still use the main branch) but useful if we want to quickly try a 'doc-builder' PR on another library repo. Should avoid to push a temporary commit like this next time: #398 (comment)
cc @mishig25 @xenova