SeamlessM4T: test_retain_grad_hidden_states_attentions is flaky#28035
Merged
gante merged 2 commits intohuggingface:mainfrom Dec 14, 2023
Merged
SeamlessM4T: test_retain_grad_hidden_states_attentions is flaky#28035gante merged 2 commits intohuggingface:mainfrom
test_retain_grad_hidden_states_attentions is flaky#28035gante merged 2 commits intohuggingface:mainfrom
Conversation
amyeroberts
reviewed
Dec 14, 2023
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks!
Instead of a TODO comment, could you create a github issue and tag @ylacombe ?
amyeroberts
approved these changes
Dec 14, 2023
gante
commented
Dec 14, 2023
iantbutler01
pushed a commit
to BismuthCloud/transformers
that referenced
this pull request
Dec 16, 2023
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
@is_flaky()decorator totest_retain_grad_hidden_states_attentionsin SeamlessM4T, as it is a flaky test with a ~11% failure rate.As discussed internally on Slack.