Skip to content

disable test_retain_grad_hidden_states_attentions on SeamlessM4TModelWithTextInputTest#28169

Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom
dwyatte:disable_retain_grad_tests
Dec 21, 2023
Merged

disable test_retain_grad_hidden_states_attentions on SeamlessM4TModelWithTextInputTest#28169
ArthurZucker merged 1 commit intohuggingface:mainfrom
dwyatte:disable_retain_grad_tests

Conversation

@dwyatte
Copy link
Copy Markdown
Contributor

@dwyatte dwyatte commented Dec 20, 2023

What does this PR do?

Disables tests/models/seamless_m4t/test_modeling_seamless_m4t.py::SeamlessM4TModelWithTextInputTest::test_retain_grad_hidden_states_attentions as discussed in #28144 (comment)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@amyeroberts

Copy link
Copy Markdown
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing so quickly!

cc @ylacombe

@ArthurZucker
Copy link
Copy Markdown
Collaborator

Related to #28035 and #28060 which should have already skipped it

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ArthurZucker ArthurZucker merged commit e268d7e into huggingface:main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants