Skip M4T test_retain_grad_hidden_states_attentions #28060
Merged
ylacombe merged 2 commits intohuggingface:mainfrom Dec 15, 2023
Merged
Skip M4T test_retain_grad_hidden_states_attentions #28060ylacombe merged 2 commits intohuggingface:mainfrom
test_retain_grad_hidden_states_attentions #28060ylacombe merged 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
Thanks for fixing! If training is allowed to happen on the model but it can fail e.g. with attentions being None, could you open an issue to track this? Training should either be prevented with an exception or made possible (probably 1 then the other) |
Contributor
Author
|
Hey @amyeroberts, in theory, training is supported for the tasks that translate inputs (text or audio) into texts, since it's a classic LLM with classic objective. |
iantbutler01
pushed a commit
to BismuthCloud/transformers
that referenced
this pull request
Dec 16, 2023
* skip test from SpeechInput * refine description of skip
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After investigating the reasons for the
test_retain_grad_hidden_states_attentionsflaky failure, I realized the speech encoder attentions can beNonewith a non-zero probability whentraining=True. Skipping the test is the fastest fix.Fixes #28036
cc @gante @amyeroberts @ydshieh