[BUG] BarkEosPrioritizerLogitsProcessor eos_token_id use list, tensor size mismatch#28201
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Jan 10, 2024
Merged
Conversation
cd3e90d to
9f1faed
Compare
…eos_token_id use list, tensor size mismatch
9f1faed to
ce52bef
Compare
gante
approved these changes
Jan 9, 2024
Contributor
gante
left a comment
There was a problem hiding this comment.
LGTM 👍 Thank you for reporting and fixing the issue! 💛
Contributor
|
(cc @ylacombe ) |
ArthurZucker
approved these changes
Jan 10, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks for the fix and taking the time to add a test 🤗
Contributor
|
Thanks for fixing @inkinworld ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bug about
transformers.generation.logits_process.BarkEosPrioritizerLogitsProcessor.when
BarkEosPrioritizerLogitsProcessoreos_token_id use list, tensor size mismatch.such as below test case:
will occur this exception
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@gante