Fix the check of models supporting FA/SDPA not run#28202
Merged
Conversation
ydshieh
changed the title
ydshieh
force-pushed
the
fix_support_list_test_not_run
branch
from
8359110 to
7314d18
Compare
Contributor
|
i create the pr(#28201) check failed casue by |
amyeroberts
approved these changes
Dec 22, 2023
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for fixing this so quickly!
Contributor
|
@inkinworld Yes, once this PR has been merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The original check (as test methods) in
tests/utils/test_doc_samples.pywon't run (and didn't run like in #28133) as that file is not impacted by the modeling files (in terms of import relation).Those 2 checks don't need
torchat all and could be done in the first stage of check (check_repository_consistency)