Add DINOv2 with registers (using diff)#32905
Add DINOv2 with registers (using diff)#32905NielsRogge wants to merge 12 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
left a comment
There was a problem hiding this comment.
Super nice! thanks for using diff, really fits well
|
@ArthurZucker thanks for the review, addressed your comments. Note that there were still some issues with the diff converter (see my first message), but other than that this PR seems ready |
|
Support for dinov2 with registers would be very much appreciated! |
|
#33248 will resolve all your issues 🤗 |
|
I'll ask you to wait a tiny little bit as it will conflict with this work! |
Looks like Modular transformers: modularity and inheritance for new model additions #33248 was merged a few hours ago! |
|
Yep! Make sure to rebase! |
|
I think I did the wrong @ initially. @NielsRogge do you have time to rebase and update? If not, we can give it a go.
|
|
Hi, feel free to take over, it's probably easy as only one method needs to be overwritten. |
|
Closing this one, will try out the new modular Transformers when I have time |
What does this PR do?
This PR is a follow-up of #31832 but uses the diff instead of rewriting from scratch.
Had 2 issues with the diff:
drop_pathfunction was causing an issue. Applying the suggestion at #31832 fixed it.super().__init__()to the Backbone class. I manually added it in the modeling file as otherwise there's an error.