Skip to content

Add Dinov2 with registers#35245

Closed
BernardZach wants to merge 0 commit intohuggingface:mainfrom
innovationcore:main
Closed

Add Dinov2 with registers#35245
BernardZach wants to merge 0 commit intohuggingface:mainfrom
innovationcore:main

Conversation

@BernardZach
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR is a continuance of #32905 by @NielsRogge.

When running pytest there were two errors:

ERROR examples/research_projects/codeparrot/scripts/tests/test_deduplicate.py
ERROR templates/adding_a_missing_tokenization_test/cookiecutter-template-{{cookiecutter.modelname}}/test_tokenization_{{cookiecutter.lowercase_modelname}}.py

I am not sure what the problem for these are. Any guidance would be appreciated.

Relevant Reviewers
@ArthurZucker

@NielsRogge
Copy link
Copy Markdown
Collaborator

Hi @BernardZach could you add me as a collaborator to your branch? Will push some fixes

@BernardZach
Copy link
Copy Markdown
Contributor Author

@NielsRogge I believe I added you in the correct spot. Let me know if there are any issues.

@NielsRogge
Copy link
Copy Markdown
Collaborator

Hi @BernardZach I've investigated the issue, when running the modular converter, it changes the modeling code in a non-equivalent way, causing various tests to fail. I've pinged @Cyrilvallez about it

@walsvid
Copy link
Copy Markdown

walsvid commented Dec 19, 2024

Hi all, I was wondering if there are any updates on this PR?

@NielsRogge NielsRogge closed this Dec 19, 2024
@NielsRogge
Copy link
Copy Markdown
Collaborator

NielsRogge commented Dec 19, 2024

Fixed all tests :) Hmm for some reason my push made this PR closed. My branch is here: https://github.com/huggingface/transformers/compare/main...NielsRogge:add_dinov_2_registers_innovationcore?expand=1.

I wanted to push it here by doing git push innovationcore main but for some reason that closed your PR. The issue might be that you're working on the main branch - normally a PR is never on the main branch

I've set you as remote, git remote -v gives:

innovationcore  git@github.com:innovationcore/transformers.git (fetch)
innovationcore  git@github.com:innovationcore/transformers.git (push)

@NielsRogge
Copy link
Copy Markdown
Collaborator

Opened #35348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants