Add Dinov2 with registers#35245
Add Dinov2 with registers#35245BernardZach wants to merge 0 commit intohuggingface:mainfrom innovationcore:main
Conversation
|
Hi @BernardZach could you add me as a collaborator to your branch? Will push some fixes |
|
@NielsRogge I believe I added you in the correct spot. Let me know if there are any issues. |
|
Hi @BernardZach I've investigated the issue, when running the modular converter, it changes the modeling code in a non-equivalent way, causing various tests to fail. I've pinged @Cyrilvallez about it |
|
Hi all, I was wondering if there are any updates on this PR? |
|
Fixed all tests :) Hmm for some reason my push made this PR closed. My branch is here: https://github.com/huggingface/transformers/compare/main...NielsRogge:add_dinov_2_registers_innovationcore?expand=1. I wanted to push it here by doing I've set you as remote, git remote -v gives: |
|
Opened #35348 |
What does this PR do?
This PR is a continuance of #32905 by @NielsRogge.
When running pytest there were two errors:
ERROR examples/research_projects/codeparrot/scripts/tests/test_deduplicate.py
ERROR templates/adding_a_missing_tokenization_test/cookiecutter-template-{{cookiecutter.modelname}}/test_tokenization_{{cookiecutter.lowercase_modelname}}.py
I am not sure what the problem for these are. Any guidance would be appreciated.
Relevant Reviewers
@ArthurZucker