[Moshi] disable automatic compilation#35986
Closed
gante wants to merge 2 commits intohuggingface:mainfrom
Closed
Conversation
Contributor
Author
|
Sorry, I'm closing this -- I've found a much better solution 😅 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes moshi + generation, which is making our ci quite red.
#34544 expanded automatic compilation when any compileable cache is used
Moshi uses sliding window cache by default, which is a compileable cache. However, Moshi doesn't support compilation. This PR ensures all caches are tagged as non-compileable for Moshi at generation time, to prevent automatic compilation from happening.