[Moshi] disable automatic compilation if the model can't compile#35992
[Moshi] disable automatic compilation if the model can't compile#35992gante merged 2 commits intohuggingface:mainfrom
Conversation
ydshieh
left a comment
There was a problem hiding this comment.
LGTM.
I have a previous PR somehow related to this situation
I kind start feeling _supports_static_cache is a bit misleading, as now it turns out meaning we can use static cache, but compilation will fail, but it's more a naming issue.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@ydshieh I agree the name is misleading, and has been repurposed for compilation things. Happy to rename it to |
|
I would love it renamed, but since it's an (despite being private) attribute of the important/base class (and we can do it in a separate PR, so you can merge this one quickly if you wish) |
|
yes, let's do it in a separate PR :) |
What does this PR do?
Don't trigger automatic compilation if the model can't compile. #34544 enabled automatic compilation with any compilation-ready cache. However, some models default to compilation-ready caches AND don't support compilation, e.g. Moshi
Supercedes #35986; Carved from #35989 to reduce the size of that PR.
Fixes Moshi generation tests, e.g.
py.test tests/models/moshi -k test_greedy_generate -vv