[qwen] refactor attentions for vision/audio#38930
Merged
zucchini-nlp merged 6 commits intohuggingface:mainfrom Jun 24, 2025
Merged
[qwen] refactor attentions for vision/audio#38930zucchini-nlp merged 6 commits intohuggingface:mainfrom
zucchini-nlp merged 6 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
approved these changes
Jun 20, 2025
Member
Cyrilvallez
left a comment
Cyrilvallez
left a comment
There was a problem hiding this comment.
Very very much welcome!! 🤗 Main concern is about the kwargs here, they are not flowing correctly in this PR, and I'm not sure if we can flow them all the way in general (e.g., some seqlens passed as kwargs for the language model would clash with those explicitly defined in the other modalities), i.e. does it make sense to have them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per title, these modalities were left out when refactoring VLMs earlier