Skip to content

Fixed flash attention 2 crash in qwen vl and omni models#39110

Closed
petkokp wants to merge 1 commit intohuggingface:mainfrom
petkokp:qwen_attention_fix
Closed

Fixed flash attention 2 crash in qwen vl and omni models#39110
petkokp wants to merge 1 commit intohuggingface:mainfrom
petkokp:qwen_attention_fix

Conversation

@petkokp
Copy link
Copy Markdown

@petkokp petkokp commented Jun 29, 2025

What does this PR do?

Fixes #39095

The changes introduced by this refactoring are the reason for the issue #38930

This appear reverts the refactoring.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@petkokp petkokp closed this Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Qwen2_5_VLVisionAttention with flash attention has no is_causal attribute

1 participant