Skip to content

Fix audio-related config naming for Gemma3n #39103

Open
ywang96 wants to merge 1 commit intohuggingface:mainfrom
ywang96:rename-audio-code
Open

Fix audio-related config naming for Gemma3n #39103
ywang96 wants to merge 1 commit intohuggingface:mainfrom
ywang96:rename-audio-code

Conversation

@ywang96
Copy link
Copy Markdown

@ywang96 ywang96 commented Jun 28, 2025

What does this PR do?

While working on adding multimodal support for Gemma3n on vLLM, I noticed audio_soft_tokens_per_image should really be renamed to audio_soft_tokens_per_audio. This PR updates the variable naming but we'll also need to update this field in the model repository.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Signed-off-by: Roger Wang <hey@rogerw.me>
@ywang96
Copy link
Copy Markdown
Author

ywang96 commented Jun 28, 2025

I've made corresponding model config PRs in all model repositories

https://huggingface.co/google/gemma-3n-E4B-it/discussions/12
https://huggingface.co/google/gemma-3n-E4B/discussions/3
https://huggingface.co/google/gemma-3n-E2B-it/discussions/8
https://huggingface.co/google/gemma-3n-E2B/discussions/3

Maybe @zucchini-nlp you can take a look and let me know what you think? Thanks!

Copy link
Copy Markdown
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes total sense to me!

Though as the model was released last week in v4.53.0 and probably we have already several tuned copied of it on the hub, this should be done in a non-breaking way with a deprecation cycle (imo 1 release is enough)

evalstate added a commit to evalstate/transformers that referenced this pull request Apr 29, 2026
Applied from upstream PR huggingface#39103 (1d85c39) with local patch because the direct PR merge conflicts with current Gemma3n v5/strict config docstring structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants