Cumulative defect fixes from recent Transformers PRs#43
Open
Cumulative defect fixes from recent Transformers PRs#43
Conversation
Per @Rocketknight1's review: replace the ad-hoc `_no_reinit` flag with the existing `_is_hf_initialized` flag that `from_pretrained` already sets on checkpoint-loaded parameters. Guard each Mamba2 init target (A_log / D / dt_bias) and the residual-scaled `out_proj.weight` independently, so parameters restored from a checkpoint survive any subsequent `_init_weights` pass.
Fixed 4 test(s): - tests/models/qianfan_ocr/test_modeling_qianfan_ocr.py::QianfanOCRIntegrationTest::test_model_integration_batched_generate - tests/models/qianfan_ocr/test_modeling_qianfan_ocr.py::QianfanOCRIntegrationTest::test_model_integration_forward - tests/models/qianfan_ocr/test_modeling_qianfan_ocr.py::QianfanOCRIntegrationTest::test_model_integration_generate - tests/models/qianfan_ocr/test_modeling_qianfan_ocr.py::QianfanOCRIntegrationTest::test_model_integration_generate_text_only
Only installing transformers[serving] failed to launch transformers serve due to the lack of requests dependency
Add 'requests' to serving extras dependencies
…ined When a caller passes a pre-built sub-processor via kwargs to `AutoProcessor.from_pretrained` (e.g. `tokenizer=tok` or `bpe_tokenizer=tok`), use the instance directly instead of silently forwarding it into the sub-loader calls. Exact attribute names take precedence; the canonical modality name is also accepted as an alias when a single sub-processor has that modality.
…rleaving renames and converts ops
# Conflicts: # src/transformers/modeling_utils.py
# Conflicts: # src/transformers/loss/loss_utils.py
# Conflicts: # src/transformers/models/gpt2/configuration_gpt2.py
# Conflicts: # src/transformers/models/doge/modeling_doge.py # src/transformers/models/doge/modular_doge.py
Adapted from huggingface#39999 because tensor parallel setup moved from modeling_utils.py to integrations/tensor_parallel.py.
# Conflicts: # src/transformers/trainer.py
Direct merge of 9ec50bc conflicted after Trainer refactors; apply equivalent current-code guard.
Direct merge of ee690bc conflicted after Trainer/TrainingArguments refactors; apply the current-code equivalent for misaligned save/eval steps.
# Conflicts: # setup.py
# Conflicts: # src/transformers/utils/generic.py
Owner
Author
All-defects flow statusProcessed terminal records: 762 Merged / applied defect records (244)
Rejected / not included records (518)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cumulative defect fixes from recent Transformers PRs
This PR is generated by the all-defects mergeability flow. It accumulates defect-fix PRs from
huggingface/transformersthat could be applied cleanly to the current base.all-defects-750evalstate/transformers:main2143f93a30Status counts
Category counts
Validation
Each applied defect fix was followed by the configured lightweight validation profile:
compileall -q src/transformersutils/checkers.py ruff_check,ruff_format,init_isort,sort_auto_mappingsutils/tests_fetcher.py ... && pytest ...when impacted pytest targets are selectedNote: this is intentionally not an end-to-end or slow-test validation pass.
Details
A detailed status table is posted as a PR comment and is also available locally in:
.mergeability/defect-merge-state.jsonl.mergeability/pr-classifications.jsonlall-defects-report.md