[ViLT] Refactor output handling to align with standardized patterns#44098
Open
aman-coder03 wants to merge 2 commits intohuggingface:mainfrom
Open
[ViLT] Refactor output handling to align with standardized patterns#44098aman-coder03 wants to merge 2 commits intohuggingface:mainfrom
aman-coder03 wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: vilt |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors ViLT's output handling to align with the standardized patterns used across the codebase.
Key changes:
hidden_states/attentionspropagation and passesoutput_attentions,output_hidden_states, andreturn_dictcleanly through the encoder call inViltModel.forward**kwargsforwarding to all child modelself.vilt(...)calls (ViltForMaskedLM,ViltForQuestionAnswering,ViltForImageAndTextRetrieval,ViltForTokenClassification) so output flags are correctly propagated from the top-level forward call down to the base modelViltForTokenClassificationto handle theinputs_embedspath correctly when computingtext_input_sizeViltForImagesAndTextClassificationto returnNoneinstead of empty lists forhidden_statesandattentionswhen not requested, ensuring correct output length countingWhy is this needed?
This aligns ViLT with the new output handling patterns introduced in #43979.