[Improvement] Update DistributedLengthGroupedSampler to allow customizing length function#43363
Open
Dogacel wants to merge 1 commit intohuggingface:mainfrom
Open
Conversation
…edLengthGroupedSampler
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43363&sha=0e9367 |
Author
|
Can I get some 👀 or guidence on how to move forward? |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
length_functo theDistributedLengthGroupedSamplerto support length grouping complex data.mega_batch_multfor fine-grained control of internal batching.input_idswith first dimension as length, (2) using sampler with custom length function with custom data.Motivation: We had inputs shaped as
{"input_ids": torch.Tensor(1, seq_len)}, therefore callinglen(...)resulted in returning 1 instead of seq_len, causing length grouping to fail.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
@SunMarc @3outeille
Also I would like to know if you are interested in adding documentation for this class in the website as I find it pretty useful, however website never mentions this and I foudn it by chance while reading the source and issues.