[executorch] Update pytree registration for DynamicCache#41901
Open
justinchuby wants to merge 3 commits intohuggingface:mainfrom
Open
[executorch] Update pytree registration for DynamicCache#41901justinchuby wants to merge 3 commits intohuggingface:mainfrom
justinchuby wants to merge 3 commits intohuggingface:mainfrom
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Member
|
cc @gante for cache as well |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update pytree registration for DynamicCache. Before this change the cache values are flatten as
(key0, key1, ..., value0, value1, ...). This change matches the old cache interface by flattening to(key0, value0, key1, value1, ...). This ordering matches transformers conversion and is consistent with expectation of downstream tools when they see ky caches.The change is BC breaking in that it will change the signature of the exporter program. But this is ok since (1) there is going to be transformers 5.0 (2) executorch doesn't rely on this api. Only ONNX does at this point. (3) the original implementation was wrong (pytorch/pytorch#165395)
Also fixes pytorch/pytorch#165395.
cc @titaiwangms @xadupre @jackzhxng @tugsbayasgalan