fix(cli): Fix TypeAdapter NameError when pydantic is not installed#43842
Open
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Open
fix(cli): Fix TypeAdapter NameError when pydantic is not installed#43842Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Conversation
TypeAdapter was used as a type annotation at runtime, but it was only imported inside an 'if serve_dependencies_available' block. This caused NameError when pydantic is not installed. Fix by adding TypeAdapter to TYPE_CHECKING imports and using a string annotation for the type hint so it's only evaluated during type checking. Fixes huggingface#43824
mamoonali1
approved these changes
Feb 8, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a
NameError: name 'TypeAdapter' is not definederror when importing transformers without pydantic installed.Problem
The
TypeAdapterclass from pydantic was used as a type annotation in_validate_request()at line 588:However,
TypeAdapteris only imported inside anif serve_dependencies_available:block, which requires pydantic to be installed. When pydantic is not installed, Python raisesNameErrorwhen parsing the class definition.Solution
TypeAdapterto theTYPE_CHECKINGimports block"TypeAdapter"for forward referenceThis ensures the type annotation is only evaluated during static type checking, not at runtime.
Fixes #43824