Skip to content

image_transforms: fix tensor annotations#42717

Open
cebtenzzre wants to merge 3 commits intohuggingface:mainfrom
cebtenzzre:fix-tensor-annotations
Open

image_transforms: fix tensor annotations#42717
cebtenzzre wants to merge 3 commits intohuggingface:mainfrom
cebtenzzre:fix-tensor-annotations

Conversation

@cebtenzzre
Copy link
Copy Markdown
Contributor

What does this PR do?

pyright complains when I call these functions. This is because their inputs and outputs are ostensibly tensors, but have been annotated with TensorType, which is an enum.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yonigozlan @amyeroberts

Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! not sure if it makes sense to change this, as these functions can also handle numpy "tensors"

@cebtenzzre
Copy link
Copy Markdown
Contributor Author

@yonigozlan I just added some overloads for the numpy case. Either way the existing annotations are wrong because they let me do this:

center_to_corners_format(TensorType.PYTORCH)  # ok: TensorType passed

but not this:

center_to_corners_format(torch.Tensor())  # error: "Tensor" is not an instance of "TensorType"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants