Skip to content

fix/backward compatibility for tie_weights#43498

Draft
marcndo wants to merge 2 commits intohuggingface:mainfrom
marcndo:fix/backward-compat-tie-weights-43097
Draft

fix/backward compatibility for tie_weights#43498
marcndo wants to merge 2 commits intohuggingface:mainfrom
marcndo:fix/backward-compat-tie-weights-43097

Conversation

@marcndo
Copy link
Copy Markdown
Contributor

@marcndo marcndo commented Jan 26, 2026

What does this PR do?

Fix backward compatibility issue for tie_weights

Fixes # (issue) #43097

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings. No
  • Did you write any new necessary tests? No

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@marcndo
Copy link
Copy Markdown
Contributor Author

marcndo commented Jan 26, 2026

Hi @ArthurZucker, Here's a draft PR created for the issue #43097. Whenever you'r free please take a look.

Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, v5 IS breaking there is no need to keep BC its a choice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants