Skip to content

Use torch._check instead of a test to make the model Gemma3 exportable#39962

Open
xadupre wants to merge 7 commits intohuggingface:mainfrom
xadupre:gemma3_check
Open

Use torch._check instead of a test to make the model Gemma3 exportable#39962
xadupre wants to merge 7 commits intohuggingface:mainfrom
xadupre:gemma3_check

Conversation

@xadupre
Copy link
Copy Markdown
Contributor

@xadupre xadupre commented Aug 6, 2025

What does this PR do?

torch.export.export fails on a tests used to raise an exception if not true. This is replaced by torch._check to avoid torch.export.export complain about it.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

@xadupre
Copy link
Copy Markdown
Contributor Author

xadupre commented Aug 6, 2025

cc @tugsbayasgalan

@xadupre xadupre changed the title Use torch._check instead of assert to make the model exportable Use torch._check instead of assert to make the model Gemma3 exportable Aug 6, 2025
@xadupre xadupre changed the title Use torch._check instead of assert to make the model Gemma3 exportable Use torch._check instead of a test to make the model Gemma3 exportable Aug 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 6, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: aria, aya_vision, chameleon, cohere2_vision, emu3, fuyu, gemma3, got_ocr2, internvl, llava, mistral3, paligemma, paligemma2, vipllava

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant