Fix None quantization_config equivalence with omitted param in AutoModel.from_pretrained#40783
Open
albertvillanova wants to merge 1 commit intohuggingface:mainfrom
Open
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
quantization_config=Noneequivalence with omitted parameter inAutoModel.from_pretrained.Currently,
AutoModel.from_pretrainedtreats differently missing andNonequantization_config. I think passingNoneshould be treated the same as omitting the key altogether, not as an invalid quantization config.This PR:
quantization_config=Nonevs omitted parameter inAutoModel.from_pretrainedquantization_config=Nonebehaves identically to omitting the parameter entirelyProblem
When using TRL CLI with GPT OSS models, calls like:
would fail with
AttributeError: 'NoneType' object has no attribute 'to_dict', differently than:Error traceback:
See comment in downstream hotfix:
quantization_config=Nonetrl#4019 (review)CC: @qgallouedec