FIX: enable load_best_model_at_end within SaveStrategy.BEST and initialize metric_for_best_model as loss when SaveStrategy.BEST#40221
Open
thechaos16 wants to merge 4 commits intohuggingface:mainfrom
Open
Conversation
39e3020 to
b35a06d
Compare
…alize metric_for_best_model as loss when SaveStrategy.BEST Signed-off-by: thechaos16 <thechaos16@gmail.com>
evalstate
added a commit
to evalstate/transformers
that referenced
this pull request
Apr 29, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
load_best_model_at_endwhen even ifsave_strategyisbestself.state.best_global_stepwasn't updated)metric_for_best_modelwhensave_strategyisbestmetric_for_best_modelis initialized aslosswhenload_best_model_at_endis enabled, but not ifsave_strategyis set asbest. I think these two behaviors should be the same.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@zach-huggingface, @SunMarc and @qgallouedec