Skip to content

Fix: Handling fused qkv result tensor slicing for tp sharded qkv weights#44587

Draft
kmbhattt-aws wants to merge 2 commits intohuggingface:mainfrom
kmbhattt-aws:fix/correctly-handel-tp-sharded-attn-heads
Draft

Fix: Handling fused qkv result tensor slicing for tp sharded qkv weights#44587
kmbhattt-aws wants to merge 2 commits intohuggingface:mainfrom
kmbhattt-aws:fix/correctly-handel-tp-sharded-attn-heads

Conversation

@kmbhattt-aws
Copy link
Copy Markdown

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Copy Markdown
Member

cc @ArthurZucker @Cyrilvallez for TP

@Cyrilvallez
Copy link
Copy Markdown
Member

Cyrilvallez commented Mar 12, 2026

Hey @kmbhattt-aws! It's not clear to me what you're trying to achieve here? Falcon does not have a tp_plan, and phi3 replicates anyway!

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: falcon, phi3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants