You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there an issue or reproducer to show the bug that this is fixing..?
This is fixing a CLI UX bug in HfArgumentParser for Optional[bool].
Before this PR, an Optional[bool] flag behaves like a value-taking option, so passing the flag without a value errors (argparse expects an argument), even though most CLIs treat --flag as “enable”.
Reproducer:
from dataclasses import dataclass
from typing import Optional
from transformers.hf_argparser import HfArgumentParser @DataClass
class Args:
opt: Optional[bool] = None
parser = HfArgumentParser(Args)
parser.parse_args_into_dataclasses(["--opt"]) # previously errors, now sets opt=True
This PR makes Optional[bool] behave like a standard boolean flag: --opt sets True, while still allowing explicit values (--opt false) and preserving the default None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve HfArgumentParser boolean UX so
Optional[bool]arguments can be passed as flags without an explicit value.What changed
typing.Optional[bool](Union[bool, None])the same asbool | None:None--flag(no value) to parse asTruevianargs="?"+const=True--optworks without an explicit value.