Skip to content

add-loftr-keypoints-to-map#40244

Open
alexdzm wants to merge 1 commit intohuggingface:mainfrom
alexdzm:add-loftr-keypoints-to-map
Open

add-loftr-keypoints-to-map#40244
alexdzm wants to merge 1 commit intohuggingface:mainfrom
alexdzm:add-loftr-keypoints-to-map

Conversation

@alexdzm
Copy link
Copy Markdown

@alexdzm alexdzm commented Aug 18, 2025

What does this PR do?

The official demo for eloftr does not work with the current transformers because EfficientLoFTRForKeypointMatching is not instantiated when the model is called. This fixes the problem by adding it to the model mapping.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qubvel tagging you as you reviewed the pr that added this model

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@qubvel
Copy link
Copy Markdown
Contributor

qubvel commented Aug 18, 2025

Thanks for the issue! That's the problem of the code snippet, rather than transformers code, we should use AutoModelForKeypointMatching instead of AutoModel. I've fixed the snippet, let me know if that helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants