Skip to content

fix to get output of intermediate output of dinov3 for more use case#40563

Open
SangbumChoi wants to merge 1 commit intohuggingface:mainfrom
SangbumChoi:dinov3
Open

fix to get output of intermediate output of dinov3 for more use case#40563
SangbumChoi wants to merge 1 commit intohuggingface:mainfrom
SangbumChoi:dinov3

Conversation

@SangbumChoi
Copy link
Copy Markdown
Contributor

What does this PR do?

@qubvel @yonigozlan Can anyone review this simple PR?
since DINOv3 has alot of use case the output format should be enables to return intermediate hidden_states.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: dinov3_vit

Copy link
Copy Markdown
Member

@yonigozlan yonigozlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SangbumChoi! DINOv3ViTModel is still supposed to return hidden_states through _can_record_outputs and check_model_inputs, when you set output_hidden_states to True.
Can you confirm this doesn't work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants