fix to get output of intermediate output of dinov3 for more use case#40563
Open
SangbumChoi wants to merge 1 commit intohuggingface:mainfrom
Open
fix to get output of intermediate output of dinov3 for more use case#40563SangbumChoi wants to merge 1 commit intohuggingface:mainfrom
SangbumChoi wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: dinov3_vit |
yonigozlan
reviewed
Nov 3, 2025
Member
yonigozlan
left a comment
There was a problem hiding this comment.
Hey @SangbumChoi! DINOv3ViTModel is still supposed to return hidden_states through _can_record_outputs and check_model_inputs, when you set output_hidden_states to True.
Can you confirm this doesn't work?
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@qubvel @yonigozlan Can anyone review this simple PR?
since DINOv3 has alot of use case the output format should be enables to return intermediate hidden_states.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.