Add correct typing to custom images_kwargs in ProcessorsKwargs#44270
Open
yonigozlan wants to merge 1 commit intohuggingface:mainfrom
Open
Add correct typing to custom images_kwargs in ProcessorsKwargs#44270yonigozlan wants to merge 1 commit intohuggingface:mainfrom
yonigozlan wants to merge 1 commit intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: align, aya_vision, bridgetower, cohere2_vision, colqwen2, deepseek_vl, deepseek_vl_hybrid, ernie4_5_vl_moe, fuyu, gemma3, glm46v, glm4v, grounding_dino, idefics, idefics2, idefics3 |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
redpanda1995
approved these changes
Feb 25, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A lot of ProcessorsKwargs have incorrect/unspecified type hints in their ProcessorsKwargs TypedDict for their images_kwargs attribute.
Functionnaly, this did not cause issues as "_merge_kwargs" automatically picks up the correct CustomImagesKwargs to define the valid_processor_kwargs for image processors. However it is incoherent and confusing for users looking at the code and at the docs.