Fix confusing warning in EncoderDecoderModel when creating decoder_input_ids from labels#41724
Open
st81 wants to merge 3 commits intohuggingface:mainfrom
Open
Fix confusing warning in EncoderDecoderModel when creating decoder_input_ids from labels#41724st81 wants to merge 3 commits intohuggingface:mainfrom
st81 wants to merge 3 commits intohuggingface:mainfrom
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: encoder_decoder |
Collaborator
|
cc @ArthurZucker is this warning still necessary given v5 is on the roadmap? |
Contributor
Author
|
This PR has been open for about a week now. Would you mind taking a look when you get a chance? Thanks! |
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #40168
As mentioned in the issue, it's confusing that the warning
"The decoder_input_ids are now created based on the labels, no need to pass them yourself anymore"is shown even when the user doesn't passdecoder_input_ids. Fixed to show this warning only ifdecoder_input_idsis actually passed.Note that the original warning message contains two parts: one about the
decoder_input_idsissue, and another about the v4.12.0 change. I kept the latter warning message so it's still always shown, because it's a slight breaking change worth notifying users about (as discussed in here).Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?