Skip to content

Fix typo: 'seperate' -> 'separate' in mm_grounding_dino conversion sc…#40385

Open
Prawal-Sharma wants to merge 1 commit intohuggingface:mainfrom
Prawal-Sharma:fix-typo-seperate-to-separate
Open

Fix typo: 'seperate' -> 'separate' in mm_grounding_dino conversion sc…#40385
Prawal-Sharma wants to merge 1 commit intohuggingface:mainfrom
Prawal-Sharma:fix-typo-seperate-to-separate

Conversation

@Prawal-Sharma
Copy link
Copy Markdown
Contributor

…ript

  • Fixed typo in convert_mm_grounding_dino_to_hf.py where 'image_seperate.weight' should be 'image_separate.weight'
  • This improves code readability and consistency

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

…ript

- Fixed typo in convert_mm_grounding_dino_to_hf.py where 'image_seperate.weight' should be 'image_separate.weight'
- This improves code readability and consistency
@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: mm_grounding_dino

@Rocketknight1
Copy link
Copy Markdown
Member

hi @Prawal-Sharma, have you confirmed that the update matches the weight name in the checkpoint? If the checkpoints use seperate, then we have to keep that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants