fix(SpeechT5Config): missing annotation on inputs_to_logits_ratio property#41132
Open
sw00 wants to merge 2 commits intohuggingface:mainfrom
Open
fix(SpeechT5Config): missing annotation on inputs_to_logits_ratio property#41132sw00 wants to merge 2 commits intohuggingface:mainfrom
inputs_to_logits_ratio property#41132sw00 wants to merge 2 commits intohuggingface:mainfrom
Conversation
eb9263c to
47c47d4
Compare
Rocketknight1
approved these changes
Sep 25, 2025
Member
Rocketknight1
left a comment
There was a problem hiding this comment.
Yep, this is an obvious bug. Thank you for the fix!
47c47d4 to
3fbf011
Compare
Member
|
Not sure why CircleCI is failing - @ydshieh can you force-merge this? It's a one-line fix that shouldn't cause problems. |
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: speecht5 |
evalstate
added a commit
to evalstate/transformers
that referenced
this pull request
Apr 29, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the missing
@propertyannotation onSpeechT5Configwhich causes failures onAutomaticSpeechRecognitionPipeline's preprocessing steps ifchunk_length_sis specified.Specifically, the following line of code will fail since
getattrwill resolve to a method instead of the value:This stacktrace is generated on this error:
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Rocketknight1 @eustlb