Token#40857
Open
ArkVex wants to merge 5 commits intohuggingface:mainfrom
Open
Conversation
Contributor
Author
|
Hey @ArthurZucker i have another pr open what shall i do? |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
hey, sorry I don't understandyour question as I only see this PR linked to this issue
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the calculation of
train_tokens_per_secondwhen resuming training from a checkpoint. Previously, the metric was calculated using global state, which could result in unrealistically high values after resuming. Now, the timer and token counters are reset when resuming, so the metric reflects only the current training session.Fixes #40560
Before submitting
train_tokens_per_secondis wrong after continuing from checkpoint #40560.Who can review?
@zach-huggingface @ArthurZucker ,