Fix: check TrainerState file exists before loading during resume#39599
Open
Petecheco wants to merge 2 commits intohuggingface:mainfrom
Open
Fix: check TrainerState file exists before loading during resume#39599Petecheco wants to merge 2 commits intohuggingface:mainfrom
Petecheco wants to merge 2 commits intohuggingface:mainfrom
Conversation
When resuming training from a checkpoint, the Trainer attempts to load \`trainer_state.json\` to recover the train batch size. However, if the file does not exist, a \`FileNotFoundError\` is raised, causing resume to fail. This patch adds a check using \`os.path.isfile\` before loading the state, consistent with other parts of the codebase. If the file is missing, a warning is logged and batch size recovery is skipped, allowing training to continue. Fixes a potential crash and improves robustness when resuming from incomplete or custom checkpoint directories.
evalstate
added a commit
to evalstate/transformers
that referenced
this pull request
Apr 29, 2026
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When resuming training from a checkpoint, the Trainer attempts to load `trainer_state.json` to recover the train batch size. However, if the file does not exist, a `FileNotFoundError` is raised, causing resume to fail.
This patch adds a check using `os.path.isfile` before loading the state, consistent with other parts of the codebase. If the file is missing, a warning is logged and batch size recovery is skipped, allowing training to continue.
Fixes a potential crash and improves robustness when resuming from incomplete or custom checkpoint directories.
Related PR #27568
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
trainer: @zach-huggingface, @SunMarc and @qgallouedec
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.