Refectored modeling_imagegpt.py to enable hooks to capture_outputs#44076
Open
mmahjoub5 wants to merge 1 commit intohuggingface:mainfrom
Open
Refectored modeling_imagegpt.py to enable hooks to capture_outputs#44076mmahjoub5 wants to merge 1 commit intohuggingface:mainfrom
mmahjoub5 wants to merge 1 commit intohuggingface:mainfrom
Conversation
1. Add _can_record_outputs = {"hidden_states":ImageGPTBlock, "attentions":ImageGPTAttention} on the PreTrainedModel subclass. Use class references, not strings
2. added capture_outputs to main loop
3. added can_return_tuple to higher level fnctions
4. dropped output_attentions, output_hidden_states, return_dict from
signatures unless required
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: imagegpt |
mmahjoub5
changed the title
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the ImageGPT implementation to adopt the new
@capture_outputsand@can_return_tupledecorators for standardized output collection, as part of #43979.The goal is to align Imagegpt with the new output capturing infrastructure and remove legacy
return_dict/output_hidden_stateshandling where possible.Changes
Integrated
ImageGPTwith_can_record_outputshidden_states,attention_weights, 'attention_outputs') usingOutputRecorder.Added
@capture_outputstoImageGPTModel.forwardReduced reliance on legacy output flags
return_dictandoutput_hidden_statesacross forward functions.FocalNetEncoderfor compatibility and reshaping logic.Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@molbap
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.